envoy-mobile icon indicating copy to clipboard operation
envoy-mobile copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

Cronvoy: Map EM Errors to Cronet API Errors (#1594)

Open colibie opened this issue 2 years ago • 1 comments

Description: Converts EM's responseFlags to Cronet's API Errors Additional Description: Note that this change does not include ERR_NETWORK_CHANGED and ERR_INTERNET_DISCONNECT, as they aren't implemented yet Risk Level: Low Testing: Test included Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:]

colibie avatar Sep 21 '22 23:09 colibie

@danstahrg for cronet review

colibie avatar Sep 22 '22 09:09 colibie

@Augustyniak could you please review? This resolves the TODO you added in PR2565

@alyssawilk for the c++

colibie avatar Oct 10 '22 12:10 colibie

-> Ryan for C++ as I'm largely out this week

alyssawilk avatar Oct 13 '22 13:10 alyssawilk