react-native-view-overflow icon indicating copy to clipboard operation
react-native-view-overflow copied to clipboard

Naming: ViewWithoutOverflow

Open Haraldson opened this issue 7 years ago • 5 comments

Seeing this when inspecting the view hierarchy is just really confusing, be it if you’re on iOS or Android. Why was it named this way, when the whole point of this module is to enable overflow?

Haraldson avatar May 24 '18 14:05 Haraldson

there are some images and explanations here https://medium.com/entria/solving-view-overflow-in-android-reactnative-f961752a75cd

maybe we can add those to readme.md

sibelius avatar May 24 '18 14:05 sibelius

I understand what this module does, but the naming is confusing. What are you trying to convey with the name ViewWithoutOverflow? What does it mean that it is without overflow?

Haraldson avatar May 24 '18 14:05 Haraldson

naming things is a hard problem

what would be a good name?

sibelius avatar May 24 '18 14:05 sibelius

In my code base, I name it like this;

import OverflowableView from 'react-native-view-overflow'

This doesn’t change how it appears when inspecting of course, but it makes a lot more sense to me anyway. For iOS, you could simply exit early and return View as-is, perhaps?

Haraldson avatar May 24 '18 14:05 Haraldson

Overflowable looks good, we gonna think about it

sibelius avatar May 25 '18 20:05 sibelius