react-native-fontawesome icon indicating copy to clipboard operation
react-native-fontawesome copied to clipboard

Add platform specific handling of font files

Open noinfo opened this issue 6 years ago • 3 comments

Makes webfonts work in iOS and Android besides having to use different names in 'CSS' style.

noinfo avatar Jun 07 '18 08:06 noinfo

Can we make the user pass this as a prop instead? Having the default as the old value?

sibelius avatar Jun 07 '18 17:06 sibelius

Of course it’s technically possible but isn’t it rather clunky and unwieldy?

I mean the user would have to manually use a Platform.select whenever he uses an icon. That would make the whole thing go from easy and simple to use to quite cumbersome - it’s not even like the user could use it as is if he wants to support Android with his app he’ll have to set the prop on every single use - and with a platform.select and both possible values. Furthermore the user has to be taught which values he has to input. At that point it’s easier to just roll your own icon component...

noinfo avatar Jun 07 '18 17:06 noinfo

check if this helps https://github.com/entria/react-native-fontawesome/pull/61

sibelius avatar Aug 01 '19 12:08 sibelius