OpenScraper icon indicating copy to clipboard operation
OpenScraper copied to clipboard

Consider removing shuffle_seed option from exposed HTTP API (/api/data route)

Open DavidBruant opened this issue 6 years ago • 0 comments

Allowing the client-side to seed random numbers in the server side via an HTTP request doesn't seem like a good idea At best, it's useless because search results can easily be shuffled from the client-side At worst, it's a potential major security vulnerability (if some security-related operations are based on the same PRNG)

I'd argue in favor of removing the option altogether (less code, yay!). I'll be shuffling on the client-side.

If anything i say here is unclear, i'm happy to set up a :telephone_receiver: :-)

DavidBruant avatar Oct 17 '18 15:10 DavidBruant