traits icon indicating copy to clipboard operation
traits copied to clipboard

Remove deprecated ETSConfig.enable_toolkit

Open rahulporuri opened this issue 3 years ago • 3 comments

https://github.com/enthought/traits/blob/34fa3ca9f7b0c364531b688cd7d7b3261be59b1a/traits/etsconfig/etsconfig.py#L263-L291

rahulporuri avatar Apr 12 '21 07:04 rahulporuri

Let's schedule this alongside the removal of other deprecated features in Traits 7.0

mdickinson avatar Apr 12 '21 07:04 mdickinson

So, here is the current code concerned with this issue and from what I understand, this is needed to be removed as it is not needed neither it is being used anywhere in the package. Right? Should I just delete them and raise the PR?

https://github.com/enthought/traits/blob/c903296ab1d52eb2d0c90295c6e007fe064a9fa4/traits/etsconfig/etsconfig.py#L263-L291

Apart from this,I have a doubt. Here @property is a decorator and so it should be a function taking any callable as an argument from what I know. But, I couldn't find any definition for @property or for any other decorators too. Am I missing something? This is very confusing to me. Do let me know what's happening here if you have the time or you could refer me to other sources where I can read whatever this is. Thanks

avats-dev avatar Nov 06 '21 22:11 avats-dev

Should I just delete them and raise the PR?

You can open a PR but it might not be merged immediately as Traits 7.0 might not be the next release.

Here @property is a decorator and so it should be a function taking any callable as an argument from what I know.

Please refer to the docs https://docs.python.org/3/library/functions.html#property for a better understanding of the property builtin function and how it can be used as a @property decorator.

rahulporuri avatar Nov 08 '21 05:11 rahulporuri