mayavi icon indicating copy to clipboard operation
mayavi copied to clipboard

Added requirements files

Open vishalm opened this issue 1 year ago • 3 comments

  1. Added requirements files
  2. This is mac os based requirements files

vishalm avatar Aug 24 '24 06:08 vishalm

Thank you for your PR. I am not sure we want to fix the dependencies like this. @larsoner do you have an opinion on this?

prabhuramachandran avatar May 11 '25 14:05 prabhuramachandran

I have seen this used sometimes (e.g., in pyvistaqt), then dependabot comes through and updates something as a new release is made. Every once in a while something breaks. But in general in my experience it tends to create more busy work than help with progress. So I'm -0.5.

If we do add this, then we'd want to add a CI run that actually used the requirements.txt, and probably add a bot automerge (with suitable merge CI requirements) to mark any dependabot PR as automerge to reduce the maintenance burden. In other words, let dependabot open its PR, and it will get auto-merged if CIs are happy...

larsoner avatar May 12 '25 17:05 larsoner

@larsoner, thank you. Given how bad I have been at the releases so far, I think any more busy work is not a good idea. Let me first get the release done before we consider this.

prabhuramachandran avatar May 14 '25 06:05 prabhuramachandran