photos-web icon indicating copy to clipboard operation
photos-web copied to clipboard

Download queue

Open abhinavkgrd opened this issue 2 years ago • 4 comments

Description

Add queue to thumbnail and file Download Have set the max concurrent download to 5 for now....can discuss and change it

Also we can decide the processing order and the order in which request are pushed into the queue....

I think handling new request first is also a option as a user may want to see the photo he is currently on rather than other that had been queued before it

Test Plan

Tested by setting queue limit to 1 and see the network request happening

abhinavkgrd avatar Sep 12 '21 11:09 abhinavkgrd

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3fed48d
Status: ✅  Deploy successful!
Preview URL: https://e6bebabc.bada-frame.pages.dev

View logs

cloudflare-pages[bot] avatar Sep 12 '21 11:09 cloudflare-pages[bot]

We can increase the thumbnail download to 20-30. It should be fine to download those many thumbnails in parallel

ua741 avatar Sep 12 '21 12:09 ua741

Apart from the max concurrent download threshold, everything else looks good. If the threshold for file will also impact the export, we should also increase that to 20(?).

ua741 avatar Sep 13 '21 03:09 ua741

Apart from the max concurrent download threshold, everything else looks good. If the threshold for file will also impact the export, we should also increase that to 20(?).

No That's separate and is single threaded for now....

It directly calls the downloadFile function and gets the file bypassing the download queue

abhinavkgrd avatar Sep 13 '21 07:09 abhinavkgrd