ente icon indicating copy to clipboard operation
ente copied to clipboard

Published 20 hours ago • verified publisher icon ente-io

[Auth] New icons are not appearing

Open ialexanderbrito opened this issue 9 months ago • 4 comments

Description

New icons are not appearing, after it was updated some icons are not appearing in the auth. The ones I noticed in my account were

  • ConfigCat
  • Habbo
  • Mercado Livre
  • SendGrid

image

Version

v2.0.56

What product are you using?

Ente Auth

What platform are you using?

Mobile - Android, Desktop - Windows, Desktop - macOS, Web - Edge

ialexanderbrito avatar May 06 '24 15:05 ialexanderbrito

The code seems to be working as intended, but looks like something is up with the SVG icons :(

vishnukvmd avatar May 07 '24 06:05 vishnukvmd

Any way to add alternative names for icons? Mercado Livre is the brazilian name but in spanish is MercadoLibre (actually this is the official name, since the company is argentinian, but it does have the localized name in brazil)

maujavier91 avatar May 26 '24 05:05 maujavier91

From what I've seen, to add alternative names you need to use altNames so you can add more than one name. Sorry for the Mercado Livre mistake, I had forgotten that it has two names

ialexanderbrito avatar May 26 '24 21:05 ialexanderbrito

I can confirm that the Mercado Livre icon does not appear, even in version 3.0.4.

fco-pires avatar May 27 '24 21:05 fco-pires

Yes. I also have the same problem. The Mercado Livre icon does not appear.

clrizzi avatar May 28 '24 15:05 clrizzi

I just sent a PR that should correct the Mercado Livre icon error and I also added the alternative names so that the icon also appears. Everything should probably be working in the next version, whichever is released.

The PR number is #1981

ialexanderbrito avatar Jun 03 '24 20:06 ialexanderbrito

I just sent a PR that should correct the Mercado Livre icon error and I also added the alternative names so that the icon also appears. Everything should probably be working in the next version, whichever is released.

The PR number is #1981

Thanks, @ialexanderbrito

I just update the Auth to the new version and the icon "Mercado Livre" appeared, but in a solid yellow block on both themes: Dark and Light.

clrizzi avatar Jun 04 '24 14:06 clrizzi

@clrizzi Make sure you are on the latest version that was released, as I also had this problem in version 3.0.4, the latest version 3.0.7 came out yesterday and it was fixed

ialexanderbrito avatar Jun 04 '24 15:06 ialexanderbrito

@clrizzi Make sure you are on the latest version that was released, as I also had this problem in version 3.0.4, the latest version 3.0.7 came out yesterday and it was fixed

Thanks again, @ialexanderbrito

The Playstore and F-droid versions is outdated.... I downloaded the last version from Github and the icon is displaying correctly.

Obrigado!

clrizzi avatar Jun 04 '24 15:06 clrizzi

@ialexanderbrito I see that mercadolibre altNames were added but it doesn't appear to work for some of the alt names, the icon only appears if the name is "MercadoLivre" or "Mercado Livre", but not the spanish version "MercadoLibre" or "Mercado Libre".

maujavier91 avatar Sep 24 '24 00:09 maujavier91