Stefan Sauer
Stefan Sauer
I am actually on Tumbleweed, use gcc-12 and everything builds: ``` gcc --version gcc (SUSE Linux) 12.2.1 20220830 [revision e927d1cf141f221c5a32574bde0913307e140984] ``` Here is the full autogen output: https://gist.github.com/ensonic/ab5d4d75ab3d9f990c779b9a477d3ebf
``` > cat /etc/os-release NAME="openSUSE Tumbleweed" # VERSION="20221027" ID="opensuse-tumbleweed" ID_LIKE="opensuse suse" VERSION_ID="20221027" PRETTY_NAME="openSUSE Tumbleweed" ANSI_COLOR="0;32" CPE_NAME="cpe:/o:opensuse:tumbleweed:20221027" BUG_REPORT_URL="https://bugs.opensuse.org" HOME_URL="https://www.opensuse.org/" DOCUMENTATION_URL="https://en.opensuse.org/Portal:Tumbleweed" LOGO="distributor-logo-Tumbleweed" > git describe RELEASE_0_10-555-g833287c6 > git log --oneline | head...
FYI: would it somehow make sense to merge with https://github.com/warm-metal/csi-driver-image. I've now been playing with that one and it works nicely.
You can also hook into `release`.
According to https://github.com/antirez/lua-cmsgpack/blob/master/lua_cmsgpack.c#L946..L967 this is MIT license: https://opensource.org/licenses/MIT I'll send a PR to make this more explicit.
I think this has been fixed by https://github.com/antirez/lua-cmsgpack/commit/4d94cabed195ef47303f27e286aa0ab8e8f9a144
The CMakeFile would ideally not use: ``` find_package(Lua51 REQUIRED) ``` but pkg-config (which has a lua5.1, lua.5.2, ...) dependning on what is installed. cmake-data does not have FindLua5.2 only 5.0...
/remove-lifecycle stale
Re probes, using 'InitialDelaySeconds: 600' would be much better that hammering the starting service with requests. https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/. Luckily the workaround above worked here too.
I agree that both attributes might need different treatment. I would prefer to keep the rules simple and configure everything in the template. For kind, it is not critical since...