ide icon indicating copy to clipboard operation
ide copied to clipboard

SQL Tooltip Above Nodes

Open radeusgd opened this issue 3 years ago • 3 comments

Pull Request Description

Ensures that the tooltip in SQL visualization is displayed above other nodes by adding it directly to the front layer.

It uses onHide to remove the tooltip when the visualization is destroyed.

Important Notes

Checklist

Please include the following checklist in your PR:

  • [x] The CHANGELOG.md was updated with the changes introduced in this PR.
  • [x] The documentation has been updated if necessary.
  • [x] All code conforms to the Rust style guide.
  • [ ] All code has automatic tests where possible.
  • [ ] All code has been profiled where possible.
  • [x] All code has been manually tested in the IDE.
  • [ ] All code has been manually tested in the "debug/interface" scene.
  • [ ] All code has been manually tested by the PR owner against our test scenarios.
  • [ ] All code has been manually tested by at least one reviewer against our test scenarios.

radeusgd avatar Mar 31 '21 18:03 radeusgd

We are waiting with this PR now to check if the onHide did not introduce a regression.

wdanilo avatar Mar 31 '21 18:03 wdanilo

Hi, what is the status of this ?

wdanilo avatar Jun 02 '21 01:06 wdanilo

The API it relies on has been reverted due to a regression. It is blocked by #1356

radeusgd avatar Jun 02 '21 08:06 radeusgd