Update dashboard to design v122 (Part 1)
Pull Request Description
-
Close #9886
- Update style of buttons in Drive Bar
- Move "Home" page into a "Start" dialog
- Remove icons that are no longer needed
- Remove Backend Switcher in top bar - they have now been converted to categories
-
Incidental changes
- Refactor Backend provider so that both Remote and Local backends are available.
- This was done because both Cloud and Local backends are now easily accessible by switching tabs - the Local backend no longer has its own views with the hidden category switcher
- Refactor Backend provider so that both Remote and Local backends are available.
Important Notes
None
Code review tips
- There are a lot of changes in Settings components, for example (and in general, any component that needs to use a backend). However, most of the changes are identical, so only the approach needs to be reviewed - although the settings pages and the other pages should probably be reviewed separately.
Testing instructions
- Make sure new/changed features work, as mentioned above (drive bar, start page, drag-n-drop)
- Because of the backend changes, all flows in general should be checked, at least at a basic level:
- Sign up/sign in
- Offline mode (bottom link on login screen on desktop app)
- Checking that all settings pages work, both when logged in and not logged in
Screencasts
https://github.com/enso-org/enso/assets/4046547/d8f385e2-3355-404f-a346-035917d40cf9
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
- [x] ~~The documentation has been updated, if necessary.~~
- [x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
- [x] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
- [x] ~~Unit tests have been written where possible.~~
I guess I'll avoid stacking the move to tabs on top of this PR, as this is a big PR so there may be a lot of changes needed.
- This loader is barely moving when running cloud project
- After cmd+r when having project open in progress I no longer see calls
projects/<project_id>so I had to reload again to gain access to opened project
This loader is barely moving when running cloud project
weird, i seem to be able to reproduce on develop. seems like it might be a regression
After cmd+r when having project open in progress I no longer see calls
projects/<project_id>
ah. i guess we should store the "currently open project" immediately when the user clicks play, rather than after it actually opens. it's late though so probably won't be fixed today (and possibly will fix on the tabs PR instead.)
@somebody1234 could you please rebase onto the latest changes so I can review the PR?
@MrFlashAccount latest changes pulled.
QA ⛔️
- Can we improve the drag experience to look similar to Google Drive? Currently, if user have a lot of assets, the DND button is hidden. https://github.com/enso-org/enso/assets/61194245/066d2aa7-cbfe-415f-88ac-2e8b4738fa43
- Invitations disappeared in settings
- Buttons are not aligned (use
ariaComponents.Button)
re: 3 - most style issues were fixed in the second PR. i figured it's easier to implement it once rather than having to backport. thoughts?
2 & 3. should be addressed.
- seems like it's a bigger feature, but hopefully it's the last thing to address (after some other final refactors)
on second thought 1 will be left for later
-
After clicking
Start with a templateand closing modal I end up with this -
New empty projectand polling for status is bugged -
Should this be so weird
-
Tooltips problem https://github.com/enso-org/enso/assets/2855109/db6802ae-ded6-4b8d-b7ec-f5a96985ae9c
-
Show secret value is not aligned and doesn't work
-
Share with modal
-
Have we disabled cmd / shift + arrows multiple selection?
uhoh
fixed some things locally, some of them are still TODO:
- fixed, assuming the issue is the focus ring being cut off
- i've noticed the focus ring is inconsistent (spacing, animations) - this should probably be fixed at some point as well
- TODO
- fixed
- fixed, assuming the issue is the positioning causing issues
- fixed
- fixed
- (debugging TODO) idts - but it seems to be bugged, i can see the selection flashing for a moment before being reset to just the one row
@somebody1234 we can fix 7th on separate PR and then just fix 2nd issue here. Then we can push this to merge after all others are fixed
found the cause of 2nd, was me being silly. @PabloBuchu should be ready for re-QA now - although now's probably not the best time, lol
@MrFlashAccount just a note that this PR is blocked on your re-review
QA passed. I created one small fix https://github.com/enso-org/cloud-v2/issues/1301
lets fix the merge conflict and try to merge it today
@MrFlashAccount can you rereview and approve?