enso icon indicating copy to clipboard operation
enso copied to clipboard

Add "About app" modal

Open somebody1234 opened this issue 1 year ago • 4 comments

Pull Request Description

  • Close #9433
    • Add modal displaying version info of the app

Important Notes

None

Screenshots

In browser (both cloud entrypoint, and accessing localhost:8080 when the desktop app is running):

image

On Electron desktop app:

image

On authentication pages: (NOTE: Chat is present, but currently disabled as intended for users with the isEnabled flag set to false. While it would be easy to change this to use the same chat API as the website, this is a design decision that is out of scope for this PR.)

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • [x] ~~The documentation has been updated, if necessary.~~
  • [x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • [x] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
  • [x] ~~Unit tests have been written where possible.~~

somebody1234 avatar May 02 '24 05:05 somebody1234

Also, I think we should be able to open the dialog via this menu as well CleanShot 2024-05-02 at 12 07 26@2x

MrFlashAccount avatar May 02 '24 09:05 MrFlashAccount

There's also 1 missing thing: maybe we want to allow users to get the versions dialog on every screen(even on the login screen)? not only on the dashboard

MrFlashAccount avatar May 02 '24 09:05 MrFlashAccount

QA #1 ✅ Passed with a few moments to fix:

  1. The label should be aligned vertically with the first line: image

  2. Can we just not show this button on the Login screen? CleanShot 2024-05-14 at 10 10 26@2x

MrFlashAccount avatar May 14 '24 07:05 MrFlashAccount

re 2: yeah. the intention was for chat to eventually work when logged out, but i guess it's not particularly useful as it is currently

somebody1234 avatar May 14 '24 07:05 somebody1234