enso icon indicating copy to clipboard operation
enso copied to clipboard

Show Language Server Logs

Open somebody1234 opened this issue 1 year ago • 5 comments

Pull Request Description

  • :warning: Depends on https://github.com/enso-org/cloud-v2/pull/1183 and SHOULD NOT be merged in before that PR.
  • Frontend side of https://github.com/enso-org/cloud-v2/issues/1046
    • Add endpoint to list project sessions
    • Add button to project sessions to view logs associated with a specific project session

Important Notes

None

Testing instructions

Just make sure that:

  • the new project sessions tab works (and does not show up for non-projects)
  • logs show up as expected.

Screenshots

Project sessions list: image

Logs modal: image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • [x] ~~The documentation has been updated, if necessary.~~
  • [x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • [x] All code follows the Scala, Java, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • [x] ~~Unit tests have been written where possible.~~
    • [x] ~~If GUI codebase was changed, the GUI was tested when built using ./run ide build.~~

somebody1234 avatar Apr 19 '24 06:04 somebody1234

Small question, do we limit the amount of logs to show simultaneously?

MrFlashAccount avatar May 15 '24 08:05 MrFlashAccount

Small question, do we limit the amount of logs to show simultaneously?

for the time being no

somebody1234 avatar May 15 '24 08:05 somebody1234

Small question, do we limit the amount of logs to show simultaneously?

for the time being no

What'll happen if a user has more than, lets say 1 000 000 entries(50mb) of logs? Are we going to process and display all of them?

MrFlashAccount avatar May 15 '24 08:05 MrFlashAccount

@MrFlashAccount we're assuming that won't happen for the time being - we definitely want pagination and scrollback at some point, however i think it's not something we should be adding as an afterthought on a random PR

somebody1234 avatar May 15 '24 09:05 somebody1234

code review should be addressed - not 100% sure the dialog still works properly, but we can't test it unless the logs PR is deployed

somebody1234 avatar May 15 '24 09:05 somebody1234

ping @PabloBuchu for QA?

somebody1234 avatar May 30 '24 00:05 somebody1234

  1. When I open asset panel and switch from versions to session the whole dashboard (I see logging to enso) is reloading and then the session is being loaded

https://github.com/enso-org/enso/assets/2855109/1ebef0fe-8ed2-493c-81b9-ee641dc207c1

  1. Entries on the list looks like they are disabled Screenshot 2024-06-18 at 12 10 19

PabloBuchu avatar Jun 18 '24 10:06 PabloBuchu

yeah my bad, couldn't test the new changes without the lambdas being accessible, will test soon™

somebody1234 avatar Jun 18 '24 10:06 somebody1234

@PabloBuchu QA issues should be addressed now.

not sure if the session ids are ideal (since they are just the times currently)... for now should we just name them by index like we currently do with versions?

somebody1234 avatar Jun 21 '24 06:06 somebody1234

@somebody1234 can you tomorrow merge current develop? I will be able to reqa then

PabloBuchu avatar Jun 25 '24 15:06 PabloBuchu