enso icon indicating copy to clipboard operation
enso copied to clipboard

Opening and closing component browser without creating a node breaks the metadata

Open AdRiley opened this issue 1 year ago • 3 comments

Create a simple workflow (or any workflow) like so

image

Open the component browser by pressing enter or the plus button.

image

Imagine user has now changed their mind and wants to close the component browser.

Click on the graph editor background.

Expected behaviour:

Component browser is closed and no new component is added.

Actual behaviour:

Metadata gets broken, so layout is lost. A = component gets created

image

AdRiley avatar Feb 20 '24 09:02 AdRiley

Clicking-off the opened component browser always accepted the input - this was by design, to keep it consistent with other fields (like numeric/text widget)

The lost metadata are indeed an issue

farmaazon avatar Feb 20 '24 10:02 farmaazon

But in this case I didn't input anything in the component browser.

AdRiley avatar Feb 20 '24 10:02 AdRiley

This is much better in the ide2-enso-win-x64-2024.1.1-nightly.2024.2.21 build. Everything reported is fixed :).

But in testing I found one more. If you drag from an existing component and then click off without typing anything it produces a strange rhs component

image

Again in this case I think it shouldn't create a component.

AdRiley avatar Feb 21 '24 08:02 AdRiley

@AdRiley What you see is an argument placeholder for the dot operator right-hand side, since the default node expression (operator1.) includes the trailing dot. This isn't really a bug, more like a missing feature to remove that dot. An implementation of that is already in progress by @farmaazon.

Frizi avatar Feb 21 '24 13:02 Frizi

OK. I'll test it again after that feature is done and see if it then feels better as an end user.

AdRiley avatar Feb 21 '24 13:02 AdRiley

The PR: https://github.com/enso-org/enso/pull/9127

farmaazon avatar Feb 21 '24 15:02 farmaazon