enso icon indicating copy to clipboard operation
enso copied to clipboard

Fix ESLint errors, add some docs

Open somebody1234 opened this issue 1 year ago • 4 comments

Pull Request Description

  • Fix ESLint errors
  • Add documentation for some functions with blank documentation

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • [x] ~~The documentation has been updated, if necessary.~~
  • [x] ~~Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.~~
  • [x] All code follows the Scala, Java, TypeScript, and Rust style guides. In case you are using a language not listed above, follow the Rust style guide.
  • [x] ~~Unit tests have been written where possible.~~
  • [x] ~~If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries, or the Snowflake database integration, a run of the Extra Tests has been scheduled.~~
    • ~~If applicable, it is suggested to paste a link to a successful run of the Extra Tests.~~

somebody1234 avatar Oct 16 '24 14:10 somebody1234

@somebody1234 Can we put reformat/fix eslint commits into .git-blame-ignore-revs?

MrFlashAccount avatar Oct 17 '24 07:10 MrFlashAccount

@MrFlashAccount yeah, definitely. although of course we probably want to do that in a follow up PR

somebody1234 avatar Oct 17 '24 09:10 somebody1234

@farmaazon ready for re-CR i think?

somebody1234 avatar Oct 17 '24 09:10 somebody1234

my bad! i dunno how i missed those missing @internal docs...

somebody1234 avatar Oct 18 '24 09:10 somebody1234