enso icon indicating copy to clipboard operation
enso copied to clipboard

[WIP] Bazel build system

Open Frizi opened this issue 1 year ago • 4 comments

Pull Request Description

Created a bazel-based build system, implemented a whole GUI build target within it.

Currently this PR open in order to develop and test the github actions workflow.

Frizi avatar Oct 16 '24 12:10 Frizi

Not really ready for review yet, just enabling the PR to ensure the runners are scheduled.

Frizi avatar Oct 16 '24 12:10 Frizi

uh oops

somebody1234 avatar Oct 16 '24 12:10 somebody1234

i'm wondering how the dev scripts work now - specifically how does vite replace $config with process.env?

somebody1234 avatar Oct 16 '24 12:10 somebody1234

i'm wondering how the dev scripts work now - specifically how does vite replace $config with process.env?

When you are running dev server, it works as it used to. The $config just grabs the envs from the running process. When running bazel workflow, for now the .env file is not automatically taken into account, you have to source it first into your shell manually. Still work in progress ;)

Frizi avatar Oct 16 '24 12:10 Frizi

🧪 Storybook is successfully deployed!

📊 Dashboard:

  • 👀 Review changes: https://www.chromatic.com/build?appId=673738989fc3e8430364197e&number=1032
  • 👨‍🎨 Preview storybook: https://673738989fc3e8430364197e-dredtpfxpl.chromatic.com/

github-actions[bot] avatar Dec 19 '24 16:12 github-actions[bot]

Please run the nightly workflow on this branch to make sure that it does not break the release https://github.com/enso-org/enso/actions/workflows/nightly.yml

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Nightly Release · Workflow runs · enso-org/enso

4e6 avatar Dec 20 '24 12:12 4e6

Otherwise, I'm ok with the change even though it edits the generated workflow files. I can update the workflow generation logic after the merge to unblock the progress on the Bazel build.

4e6 avatar Dec 20 '24 12:12 4e6

I'm ok with the change even though it edits the generated workflow files.

@4e6 Oh, it is not supposed to do that. Running cargo run --package enso-build-ci-gen does no changes to the workflow files. Can you point me at these edits?

vitvakatu avatar Dec 20 '24 12:12 vitvakatu

Running cargo run --package enso-build-ci-gen does no changes

Sorry, I did not notice the changes in ci_gen.rs because the run script was moved under the build tools

4e6 avatar Dec 20 '24 12:12 4e6

Does this change anything about our daily dev workflow or are the changes only relevant to CI?

radeusgd avatar Dec 20 '24 13:12 radeusgd

Does this change anything about our daily dev workflow or are the changes only relevant to CI?

The changes are made specifically to not require any local setup changes yet. Things that are already fully ported to bazel right now run automatically. Everything else stays the same for now.

Frizi avatar Dec 20 '24 13:12 Frizi