enso icon indicating copy to clipboard operation
enso copied to clipboard

Run Audit Log tests against real cloud environment

Open radeusgd opened this issue 5 months ago • 1 comments

Currently, our Audit Log tests are only ran on the Mock cloud (http-test-helper). That is because the endpoint used to fetch logs currently is supposed to return ALL logs (which is far too much data), and in practice it just seems to return []. So we rely on this endpoint in the mock instead.

This however poses the risk that changes in the cloud may cause regressions in the audit log implementation that can go unnoticed, because we do not have relevant tests.

This was inspired by my work on #10918 - I accidentally switched to real cloud and only then realized that I understand the endpoint definition wrong and was sending messages in wrong format. Because the Mock was implemented also by me, based on the understanding of the format - it was consistently wrong and so the tests were passing.

I also remember the actual cloud returning lists of events on the log_events endpoint, but now I see only empty list. This also seems like a regression that could have been caught if we had such tests.

Of course such testing will make most sense after we start running the Cloud tests on the CI (#9523).

radeusgd avatar Aug 29 '24 10:08 radeusgd