ens-contracts icon indicating copy to clipboard operation
ens-contracts copied to clipboard

Replace abstract NameResolver contract with import in ReverseRegistrar.sol

Open AboldUSER opened this issue 2 years ago • 2 comments

This pull replaces the abstract contract named NameResolver in the file ReverseRegistrat.sol with an import of the NameResolver from it's respective .sol file. I've come across hardhat compiler issues when using the ens-contracts npm package in my own projects due to two NameResolver contracts existing.

AboldUSER avatar Sep 30 '22 22:09 AboldUSER

Thanks for this! Sorry we've been busy and I haven't been able to check external PRs for a while. Happy to merge this if we can resolve the conflicts!

jefflau avatar Apr 05 '23 08:04 jefflau

Hey @jefflau I rebased my previous changes on top of the current ens-contracts master branch and looks like the conflicts resolved. Let me know if anything else is needed for this pr!

AboldUSER avatar Apr 05 '23 21:04 AboldUSER