route_translator icon indicating copy to clipboard operation
route_translator copied to clipboard

Published 20 hours ago • verified publisher icon enriclluelles

Drop the engine support

Open tagliala opened this issue 7 years ago • 2 comments

I'm going to drop the engine support, because it is buggy and the implementation is partial.

A proper engine support should

  1. Preserve the engine helper (#166); and
  2. Should not duplicate :locale in paths (#173).

If there is someone that would contribute to this and submit a PR, please make sure that the aforementioned points are checked

tagliala avatar Dec 03 '17 15:12 tagliala

Wow, we are using the engine mount feature and worked around the first problem successful (see https://github.com/enriclluelles/route_translator/issues/166#issuecomment-759423140) I think it is possible to implement this in route_translator.

The second problem (addressed in #173) does not hit us, cause we don't use route_translator inside the mounted engine. But it looks like there should be a solution.

I am against dropping this feature, cause even in its current state it is usefull for us. I can help to provide a fix to #166, if the project is interested.

aiomaster avatar Jan 16 '21 12:01 aiomaster

I can help to provide a fix to #166, if the project is interested.

Thanks!

I will not drop it for the moment. It took 3 years to release the breaking change explained in #171 to fix #87

If you know how to improve the engine support, feel free to submit a PR, it will be very welcomed

tagliala avatar Jan 16 '21 12:01 tagliala