enquirer icon indicating copy to clipboard operation
enquirer copied to clipboard

Why are properties like AutoComplete not enumerable?

Open michaelstack opened this issue 6 years ago • 2 comments

I am new to enquirer. I started by trying to use AutoComplete in a typescript project and found that it wouldn't import with import { AutoComplete } from 'enquirer'.

I later found issue #135, so I realise that there are issues with the typescript definitions.

Before finding #135, I experimented with different imports and requires, and console.logged the resultant object. I saw that the AutoComplete property does exist, but is not enumerable.

I am curious, why is AutoComplete not enumerable?

It is part of the public interface of this package.

Is it intentionally made this way because there is some benefit?

michaelstack avatar Feb 11 '20 05:02 michaelstack

Is it intentionally made this way because there is some benefit?

We're not TypeScript users, but we'd love some help implementing and maintaining consistent, reliable, TypeScript definitions. We do have some PRs, but we don't even know the right questions to ask about the code in the TypeScript PRs, and I don't like merging in code I don't understand. Really, as much as I appreciate the PRs (truly), I would prefer that we had someone who could help maintain the TypeScript definitions over time.

All of that... plus we've been working hard on the next release and it has some major changes. So we just haven't had a lot of time to review.

jonschlinkert avatar Apr 08 '20 09:04 jonschlinkert

We're not TypeScript users, but we'd love some help implementing and maintaining consistent, reliable, TypeScript definitions. We do have some PRs, but we don't even know the right questions to ask about the code in the TypeScript PRs, and I don't like merging in code I don't understand. Really, as much as I appreciate the PRs (truly), I would prefer that we had someone who could help maintain the TypeScript definitions over time.

@jonschlinkert – I'd be interested in helping make that happen. I maintain several large TypeScript codebases (Libauth, Bitauth IDE), and I'm now depending on Enquirer for a long-term project (Bitauth CLI).

All of that... plus we've been working hard on the next release and it has some major changes. So we just haven't had a lot of time to review.

I think you mean 3.0, but the last commit in this repo's 3.0 branch was a while ago. Is the next release still under development in a public repo?

bitjson avatar Aug 04 '20 21:08 bitjson