milkdown-lab icon indicating copy to clipboard operation
milkdown-lab copied to clipboard

splitscreen re-create bug

Open mateothegreat opened this issue 1 year ago • 3 comments

When I re-creaete the editor I get the following error:

CleanShot 2024-07-20 at 10 14 35

It’s like one of the modules does not have a rules property but instead a getRules() method:

image

image

Repro:

  • https://stackblitz.com/~/github.com/mateothegreat/milkdown-lab-splitscreen-repro?file=src/main.ts:L11
  • https://github.com/mateothegreat/milkdown-lab-splitscreen-repro/blob/main/src/main.ts#L12

Any tips or pointers?

mateothegreat avatar Jul 20 '24 15:07 mateothegreat

maybe milkdown has some breakchange, i'll take a look

enpitsuLin avatar Jul 25 '24 06:07 enpitsuLin

thx to @niko-ng now this should fixed in v1.3.1

enpitsuLin avatar Aug 07 '24 08:08 enpitsuLin

I didn't see there was an issue about that from 2 weeks ago 😅 It is the exact same issue. You can close it. @mateothegreat can you confirm that the latest release fixes it?

nikoPLP avatar Aug 07 '24 08:08 nikoPLP