PhotoViewer icon indicating copy to clipboard operation
PhotoViewer copied to clipboard

Swiping does not work on iOS 5

Open pcevandijk opened this issue 13 years ago • 13 comments

Im currently testing my apps on iOS 5 and see a problem when using the EGOPhotoViewer in landscape mode. The swiping between photos does not work anymore in landscape. All works fine in portrait.

Update 1: I looked in to it somewhat further and discovered that it only does not work if you try to swipe touching the photo's but if you use any black areas next to the photo it works fine. Seems the scrollViewDidScroll events are nog coming when swiping the photo in landscape modus.

Update 2: If i disable the userInteraction of the EGOPhotoImageView it all works fine. But then you dont receive push events and cant hide / show the toolbars.

pcevandijk avatar Aug 09 '11 12:08 pcevandijk

Seems the issue happens because of two UIScrollView conflicting - script use one to establish scrolling between images and another to make zoom-in/zoom-out. On some images this construction fails. A simple workaround would be to modify EGOPhotoScrollView.h:

  1. in function initWithFrame change self.scrollEnabled = NO;
  2. in function zoomRectWithCenter change first "if" as shown:

if (self.zoomScale > 1.0f) { self.scrollEnabled = NO; [((EGOPhotoImageView*)self.superview) killScrollViewZoom]; return; } self.scrollEnabled = YES;

agonych avatar Sep 23 '11 02:09 agonych

Thanks man, works like a charm.

pcevandijk avatar Oct 05 '11 07:10 pcevandijk

This worked great here. The problem was really only happening on a very small subset of pictures.

jpm avatar Oct 18 '11 18:10 jpm

Thanks, works great!

futuretap avatar Dec 30 '11 16:12 futuretap

Thx! You save my project :)

AndreyPanov avatar Feb 09 '12 10:02 AndreyPanov

Awesome, agonych! Thumbs up for you.

mickeyl avatar Feb 16 '12 15:02 mickeyl

You might as well consider to use Three20 library (http://three20.info/) which is newer and have a photo gallery module.

agonych avatar Feb 16 '12 21:02 agonych

Ya, thanks, I know three20, but the I prefer EGOPhotoViewer since it has fewer dependencies.

mickeyl avatar Feb 17 '12 09:02 mickeyl

Well, EGOPhotoViewer seems to be no longer developed

agonych avatar Feb 17 '12 10:02 agonych

Thanks

passerbycrk avatar Mar 04 '12 10:03 passerbycrk

W0W! Thanks a bunch for this. What I don't understand is why this is an issue for only a few photos? The only common denominator is that they are fullscreen photos, but it is not true for all full screen photos though.

Abeansits avatar Mar 11 '12 16:03 Abeansits

Sweet! this helped me as well! sure wish the owner of the repo would patch this so in the future everyone gets this fix

lancep avatar May 17 '12 19:05 lancep

Thnx!!!

appmake avatar May 09 '13 10:05 appmake