xp icon indicating copy to clipboard operation
xp copied to clipboard

Text component should not be wrapped inside a div in edit mode #9453

Open rymsha opened this issue 2 years ago • 1 comments

  • removed extra div in EDIT mode In addition empty text component renders the same (empty string) in PREVIEW and INLINE

rymsha avatar Jun 28 '22 13:06 rymsha

Codecov Report

Base: 84.04% // Head: 84.03% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (1baa55b) compared to base (8aa8187). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #9522      +/-   ##
============================================
- Coverage     84.04%   84.03%   -0.01%     
+ Complexity    19233    19230       -3     
============================================
  Files          2577     2577              
  Lines         67658    67650       -8     
  Branches       5438     5438              
============================================
- Hits          56860    56852       -8     
  Misses         8091     8091              
  Partials       2707     2707              
Impacted Files Coverage Δ
.../enonic/xp/portal/impl/rendering/TextRenderer.java 95.45% <100.00%> (-1.22%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 28 '22 13:06 codecov[bot]

Frontend is ready

ashklianko avatar Jan 11 '23 09:01 ashklianko

FYI guys. We (me and PMI) tried to remove this earlier, and it caused havoc in the Next.js project, so this has to be verified carefully before going live. In some cases it may be breaking afaik?

sigdestad avatar Jan 11 '23 16:01 sigdestad

OFC, textcomponent should ideally not be used for headless approaches.

sigdestad avatar Jan 11 '23 16:01 sigdestad