xp icon indicating copy to clipboard operation
xp copied to clipboard

Published 20 hours ago • verified publisher icon enonic

`data-portal-component-type` exist in LIVE mode

Open rymsha opened this issue 2 years ago • 3 comments

The data attributes that are designed for EDIT mode are left in LIVE mode, too. This bloats HTML. Hopefully we can remove it without side effects.

Ref #9394 .

rymsha avatar Mar 15 '22 14:03 rymsha

No can do, even we use them

sigdestad avatar Mar 15 '22 15:03 sigdestad

In this case they should appear consistently. Sometimes they are swallowed for text component.

rymsha avatar Mar 15 '22 16:03 rymsha

The reason why they are used in clients is actually the text component. Point is that people normally don't override it (it ships with default rendering). and then people cannot implement a consistent set of element identifiers to style components (i.e. add some margin between components). I have demonstrated how text components can be custom rendered, it basically means making your own implementation of "render region", so text component is handled differently from the other components.

Would actually be interesting if these attributes could be hidden in xp8

sigdestad avatar Mar 16 '22 07:03 sigdestad