xp icon indicating copy to clipboard operation
xp copied to clipboard

Move command must be able to rename node

Open vbradnitski opened this issue 3 years ago • 3 comments

Currently MoveCommand allows only to change parent path. But often rename happens together with move. Currently it is implemented in two steps. Sometimes even in more steps (rename, move, rename again - to avoid name collisions)

Extend move command to support full path (including new name). parentPath parameter must be deprecated and retrofitted, so it is never in use.

vbradnitski avatar Sep 13 '21 13:09 vbradnitski

NB! Make sure any node-level event handling also considers that node may now also be renamed. I.e. caching/indexing etc?

sigdestad avatar Mar 09 '22 09:03 sigdestad

What about audit logs, do we log both move and rename?

sigdestad avatar Mar 09 '22 09:03 sigdestad

Internally rename and move are implemented in one "Command". Only node-service API has different methods. All code which handles events has to listen for both mobe and rename because in both cases the node is "gone" from its location and appears somewhere else

rymsha avatar Jan 27 '23 07:01 rymsha