xp icon indicating copy to clipboard operation
xp copied to clipboard

SnapshotServiceImpl: no error/warning on failed snapshot deletion

Open ashklianko opened this issue 5 months ago • 0 comments

App-snapshotter runs scheduled cleanup once an hour by default, and that cleanup may fail silently in elastic with no trace in our logs if other snapshot is being created in the moment. I managed to manually reproduce the issue and catch the exception: ConcurrentSnapshotExecutionException[[enonic-xp-snapshot-repo:com.enonic.app.snapshotter--hourly2_2024-09-06t07_34_00.244781700z] another snapshot is currently running cannot delete]

Can wrap invocation of doDeleteSnapshot with try-catch block and logging within, or maybe the team can propose other solutions to this.

ashklianko avatar Sep 06 '24 10:09 ashklianko