enKrypt icon indicating copy to clipboard operation
enKrypt copied to clipboard

[FIX] Total balance not updated when withdrawal completes

Open ahsan-javaiid opened this issue 9 months ago • 4 comments

Description

This PR fixes the issue of total balance not refreshing after tx confirms. Due to this issue the individual and total balances does not match. When the withdrawal is processed, it is needed to refresh in order to see the total balance update.

Tested this on couple of EVM chains, it's happening on all EVM chains.

Snapshots

Screenshot 2025-03-14 at 3 15 21 PM (1)

Summary by CodeRabbit

  • New Features
    • The application now automatically refreshes the page once a transaction receipt is received, ensuring you always see the latest transaction status.
    • Error handling behavior remains active, continuing to notify you of any issues during processing.

ahsan-javaiid avatar Mar 18 '25 13:03 ahsan-javaiid

Walkthrough

This change adds an event listener for the receipt event within the sendAction function of the transaction sending process. Upon receiving the transaction receipt, it triggers a page reload by invoking router.go(0). The existing error handling logic remains intact.

Changes

File Change Summary
packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue Added a receipt event listener in the sendAction function to trigger a page reload with router.go(0) upon receiving the transaction receipt.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant SA as sendAction
    participant SST as sendSignedTransaction
    participant R as Router

    U->>SA: Initiates transaction sending
    SA->>SST: Calls sendSignedTransaction
    SST-->>SA: Emits receipt event
    SA->>R: Calls router.go(0) to reload page

Suggested reviewers

  • kvhnuke

📜 Recent review details

Configuration used: .coderabbit.yaml Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20d670cd663750ff1264746ff5a4d0a5fba5e1bb and c1b7136c743810b9e01cb1312b24f3e38f2d9ce0.

📒 Files selected for processing (1)
  • packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 18 '25 13:03 coderabbitai[bot]

cc: @kvhnuke for review. Thank you.

ahsan-javaiid avatar Mar 18 '25 13:03 ahsan-javaiid

@ahsan-javaiid can you rebase with latest changes

kvhnuke avatar Apr 24 '25 17:04 kvhnuke

@ahsan-javaiid can you rebase with latest changes

Done!

ahsan-javaiid avatar Apr 24 '25 17:04 ahsan-javaiid