curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Ruby Fundamentals

Open JonaC22 opened this issue 8 years ago • 17 comments

  • [x] What is Ruby?

  • [x] Numbers

  • [x] Strings & Symbols

  • [x] Variables & constants

  • [x] Conditional structures

JonaC22 avatar Feb 18 '17 18:02 JonaC22

  • [ ] https://enkipro.com/preview-insight/sagelabs/content/Ruby/Fundamentals/conditional-structures.md?ref=1fa265793e1c261c10eed9871db2e3cb12989afc
  • [ ] https://enkipro.com/preview-insight/sagelabs/content/Ruby/Fundamentals/numbers.md?ref=1fa265793e1c261c10eed9871db2e3cb12989afc
  • [ ] https://enkipro.com/preview-insight/sagelabs/content/Ruby/Fundamentals/strings-and-symbols.md?ref=1fa265793e1c261c10eed9871db2e3cb12989afc
  • [ ] https://enkipro.com/preview-insight/sagelabs/content/Ruby/Fundamentals/variables-and-constants.md?ref=1fa265793e1c261c10eed9871db2e3cb12989afc
  • [ ] https://enkipro.com/preview-insight/sagelabs/content/Ruby/Fundamentals/what-is-ruby.md?ref=1fa265793e1c261c10eed9871db2e3cb12989afc

enki-hq avatar Feb 18 '17 18:02 enki-hq

Thank you for your contribution. The content looks great so far!

lukem512 avatar Feb 20 '17 15:02 lukem512

bad indentation of a sequence entry at line 13, column 26: - ruby-lang home page ^

enki-hq avatar Feb 21 '17 13:02 enki-hq

bad indentation of a sequence entry at line 13, column 26: - ruby-lang home page ^

enki-hq avatar Feb 21 '17 13:02 enki-hq

@mathieudutour Why parent fails? Maybe because is checking against the current master branch?

JonaC22 avatar Feb 21 '17 13:02 JonaC22

Yes, I have a fix for that but I haven't deployed it yet

mathieudutour avatar Feb 21 '17 13:02 mathieudutour

This workout is done, please review it

JonaC22 avatar Feb 26 '17 16:02 JonaC22

@JonaC22 Hey Jonathan, Firstly, I feel compelled to say I was pleasently surprised by your content - it was really good to be honest. I have no knowledge of ruby and I've reviewed your insights from the point of view of a complete beginner, but also commented on few editorial details.

Thanks a bunch for contributing!

loopiezlol avatar Feb 28 '17 12:02 loopiezlol

@Loopiezlol @lukem512 It's my first time I'm contributing in english-speak content so maybe there could be a lot of corrections to do in the editorial details, but now I have learned from your comments! I'm going to do these fix as soon as I have time. Thanks for the reviews!

JonaC22 avatar Feb 28 '17 16:02 JonaC22

@mathieudutour @Loopiezlol I did corrections but it's failing in footnotes check, showing Fail for undefined. What could be the problem in the insights?

JonaC22 avatar Mar 03 '17 12:03 JonaC22

@Loopiezlol Sorry for the delay, I was away too. I did the correction and now all checks have passed, thanks! Tell me if something more is needed for this workout

JonaC22 avatar Mar 25 '17 20:03 JonaC22

🎉 🎉 🎉 🎉 🎉 🎉 @JonaC22 amazing work! These insights look great!

because these logically follow an order of display, this must be also enforced the way we did it lately was with the parent field

as you can see the in the docs this field doesn't guarantee a follow up, but if all insights in a course(subtopic) are parented one after another, the ordering works perfect.

could you add this field as well (first insight shown doesn't need it) and I'll make sure to review and push the content live.

however, due to the lack of content the ruby topic is currently unpublished. as soon as we get more content on it users will be able to benefit from your content

loopiezlol avatar Mar 28 '17 12:03 loopiezlol

@Loopiezlol Thank you for the comment! :+1: I added the parent field as you requested but unfortunately all automatic checks still failing with it

JonaC22 avatar Mar 28 '17 23:03 JonaC22

@JonaC22

weird, let me look into it

loopiezlol avatar Mar 29 '17 10:03 loopiezlol

I think it's fine: https://github.com/sagelabs/content/pull/119

maybe the server was down for a short period of time or something

mathieudutour avatar Mar 29 '17 12:03 mathieudutour

@JonaC22 could you try push another empty commit ?

loopiezlol avatar Mar 29 '17 12:03 loopiezlol

@Loopiezlol @mathieudutour Now seems to be everything fine :+1: I pushed an empty commit and then I removed it and all automatic checks passed! Thank you!

JonaC22 avatar Mar 30 '17 22:03 JonaC22