enketo-express icon indicating copy to clipboard operation
enketo-express copied to clipboard

Published 20 hours ago • verified publisher icon enketo

Docker: Use base image with Node 16?

Open jnm opened this issue 3 years ago • 2 comments

Now that #298 has been merged and Node 16 is used for CI, should we change the Dockerfile to match? I can submit a PR if desired. Thanks.

jnm avatar Oct 12 '21 20:10 jnm

I don't feel strongly about it, but seems like a reasonable thing to do. @eyelidlessness?

yanokwa avatar Nov 02 '21 16:11 yanokwa

Maybe if it's not a big deal, we can just wait. The Node 16 base image includes npm 8.1.0, and I had trouble installing libxslt with npm 7+. It does install successfully with npm 6.14.15, which comes with the Node 14 base image. We'd have to downgrade npm in our own Dockerfile, which isn't a big deal, but maybe it's not worth the effort to upgrade if Node 14 is fine for now in production.

jnm avatar Nov 09 '21 16:11 jnm

With CI now testing both Node 14 and 16, I don't think there's any need to keep this issue open.

jnm avatar Nov 01 '22 00:11 jnm