enketo-core
enketo-core copied to clipboard
enketo
Do not like thousands-sep appearance duplicate numbers in Grid theme
Describe the bug Enketo displays both comma separated value and original integer. This creates a double vision effect of the same figure.
To Reproduce Steps to reproduce this.
Refer to this link to the corresponding deployed form hosted on the Kobo server.
The form is designed with grid theme layout.
-
Go to Form link: https://ee.kobotoolbox.org/x/73Nrz2pC
-
Check xls form as sent to Kobo community forum: https://community.kobotoolbox.org/uploads/short-url/lEQAPi8OxAYN6Jq79oxv1joDP55.xlsx
Expected behavior Only the thousands-sep figure should be displayed not both.
Screenshots
Picture below:
**Browser and OS (please
completethe following information):**
- OS: WINDOWS 10
- Browser: GOOGLE CHROME
Additional context
@yanokwa @MartijnR any assistance would go along way!
No bug but current implementation is very basic. It was done to acceptably solve an immediate need without having the resources to fully implement the thousands-sep feature.
Related to https://github.com/enketo/enketo-core/issues/696
This makes sense. Is there any plan to fully implement this feature fully on enketo in the near future? Can we turn this into a pull request? I believe an update with the fully implemented appearance would be very appreciated by many.
On Thu, Jan 27, 2022 at 6:37 PM Martijn van de Rijdt < @.***> wrote:
No bug but current implementation is very basic. It was done to acceptably solve an immediate need without having the resources to fully implement the thousands-sep feature.
Related to #696 https://github.com/enketo/enketo-core/issues/696
— Reply to this email directly, view it on GitHub https://github.com/enketo/enketo-core/issues/858#issuecomment-1023343777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVYISF2SOCVYWMXISO2ZT33UYFRD3ANCNFSM5M6IQHZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
Definitely believe so. What would it take to implement some of these features? I am actually looking for someone to collaborate with (paid) on a fork off enketo. Would you be interested or recommend someone for a short term project?
On Thu, Jan 27, 2022 at 8:08 PM Martijn van de Rijdt < @.***> wrote:
I haven't heard of anybody planning this, but it could be fun I think!
— Reply to this email directly, view it on GitHub https://github.com/enketo/enketo-core/issues/858#issuecomment-1023449968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVYISF4NYXHLB5RIHWNXLT3UYF3ZZANCNFSM5M6IQHZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
Sounds cool. I'm not in charge of these repos, but it would be worth checking if @eyelidlessness and @lognaturel would be interested in a PR if you end up developing this. That way you could reduce differences with your fork as well, which will be helpful.
I'm not available myself. Anybody who committed to Enketo Core in the past would probably be a good fit.
Implementation could be a challenge depending on the requirements. I know that an acceptable PR would probably need to match ODK Collect's behavior closely (since Enketo and Collect are often used together).
You've probably seen that the current widget is only a few lines of code. I'm thinking that perhaps one simple step up would be to overlay the div showing the separated value over the number input (and hiding that input). When the div is clicked or the underlying input receives focus (by keyboard tabbing between fields e.g.), it could hide and reveal the underlying input (so 1,000,000 becomes 1000000 again). Not a fantastic user experience perhaps but you avoid complexity by being able to use a regular <input type="number">. As soon as the input field loses focus (blur event) the div could become visible again. Just some brainstorming. I may be overlooking something too.