litex icon indicating copy to clipboard operation
litex copied to clipboard

Change liblitedram/sdram.c to correctly support single x4 IC

Open mtdudek opened this issue 1 year ago • 3 comments

With out this changes DDR5 simulation hangs with DQ/DQS ratio = 4

Signed-off-by: Maciej Dudek [email protected]

mtdudek avatar Aug 18 '22 14:08 mtdudek

@enjoy-digital could you take a look?

mtdudek avatar Aug 19 '22 07:08 mtdudek

Thanks @mtdudek, I'll have a closer look very soon.

enjoy-digital avatar Aug 24 '22 17:08 enjoy-digital

Hi @mtdudek,

with this new version, the code gets difficult to apprehend. Can you change the PR to keep the previous code but just add support for the new case you want to support. This will allow merging and simplifying the review to try to share the same code for the different case. Thanks.

enjoy-digital avatar Aug 29 '22 14:08 enjoy-digital

We can probably close this since covered by https://github.com/enjoy-digital/litex/pull/1512.

enjoy-digital avatar Nov 18 '22 08:11 enjoy-digital