Mo Khan

/good-first-issue

I have not looked closely but assuming the CA used for signing serving certificates and client certificates is the same is generally not valid.

Probably should use sig-auth-leads owner alias to cover all the leads. LGTM otherwise.

> > Probably should use sig-auth-leads owner alias to cover all the leads. > > We would need to create that alias in the new repo and use it. I...

/reopen /remove-lifecycle rotten This seems like valuable functionality to have 😄

/remove-sig auth This appears to belong to SIG Node. Feel free to add back SIG Auth if needed.

Instead of a manual stop method that is a no-op in many cases I think it would be better to have a context be used to cancel any implementations that...

> > Instead of a manual stop method that is a no-op in many cases I think it would be better to have a context be used to cancel any...

/assign

We already have existing bugs for CRDs not supporting encryption at rest because the wiring is incorrect so I don't buy the argument that "we won't forget because we only...