Mathieu comments

Results 193 comments of


                                            Mathieu

epic: replace operators with their non-overflowing version

sorry no this is a big epic, it's not scoped yet what needs to be explicitly checked for overflows and how we can do this efficiently

feat: generic `from_bytes` implementation

Hi, this is paused for now

dev: add a pre-push/pre-commit hook that runs scarb fmt to avoid useless failed CIs

The culprit is the Trunk tool that overrides the local `.git/config:hooksPath` value to use trunk hooks instead of your repo's local hooks.

dev: add a pre-push/pre-commit hook that runs scarb fmt to avoid useless failed CIs

@Eikix now possible?

dev: add a pre-push/pre-commit hook that runs scarb fmt to avoid useless failed CIs

scarb in trunk now.

feat: migrate tests from scarb to sn foundry

we need `#[should_panic]` before, I made a PR to starknet-foundry to have it available (probably next week). There will be no changes to do.

feat: migrate tests from scarb to sn foundry

> -> contract first approach, must deploy contracts to test functions Not necessarily but if you want to mock stuff, then you need to do that (unlike cairo-test)

feat: migrate tests from scarb to sn foundry

Basically, imagine you want to test `is_caller_eoa`. To do that you want to mock the caller address, create your execution context, and then call `is_caller_eoa`. This is not possible in...

feat: support SNIP-9 on account contracts

yes, and the reference implementation in Cairo Zero: https://github.com/kkrt-labs/kakarot/blob/7fb90d799a5a0bfab0a48bdfcb4e867d35b4943c/src/kakarot/accounts/account_contract.cairo#L83. First try to migrate to a SNIP-9 compatible structure. For everything that can not trivially implemented, add a TODO and we'll...

feat: support SNIP-9 on account contracts

@remybar how are things going?