react-native-hold-menu icon indicating copy to clipboard operation
react-native-hold-menu copied to clipboard

Published 20 hours ago • verified publisher icon enesozturk

Expo 49 - Breaking Changes

Open hazirmagron opened this issue 1 year ago • 19 comments

Describe the bug The overlay is completely broken since I updated to Expo@49.

The 'HoldItem' child components still animate when pressed. The overlay and menu never show up, however, and the child component that was pressed is frozen on the screen.

Package versions

  • React: "18.2.0"
  • React Native: "0.72.3"
  • React Native Reanimated: "~3.3.0"
  • React Native Hold Menu: "^0.1.6"
  • Expo: "^49.0.0"

hazirmagron avatar Jul 19 '23 13:07 hazirmagron

Is this fixed yet?

holma91 avatar Aug 19 '23 09:08 holma91

Same issue

pavelbabenko avatar Aug 21 '23 15:08 pavelbabenko

I have the same issue.

raymond-tetteh avatar Sep 03 '23 13:09 raymond-tetteh

got the same issue her, any solutions suggested?

mimo-10 avatar Sep 16 '23 22:09 mimo-10

Hello guys 👋🏼

I am working on a fix here 🤓 https://github.com/enesozturk/react-native-hold-menu/pull/112

It's WIP, but I got everything working on my project

Nasseratic avatar Sep 25 '23 18:09 Nasseratic

Unfortunately same issue :(

moedeveloper avatar Sep 29 '23 23:09 moedeveloper

Hey, is there a fixed version ? I saw the new PR being WIP and changes seems to works perfecly. Did you already publish it ? Or still WIP ? Thanks ✌️

devmalcolm avatar Oct 14 '23 06:10 devmalcolm

Hey @devmalcolm

Yeah, it should be ready. But I can't publish it as I am not a contributor. Will try to bring someone to approve my PR. For now feel free to install the version in the PR by:

npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

Nasseratic avatar Oct 15 '23 11:10 Nasseratic

@Nasseratic great job, thank you!

But I think the correct command to install from your repo is (with the branch where the fix)

npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

viktor32 avatar Dec 29 '23 12:12 viktor32

Hey @Nasseratic! I've downloaded your updated version, but sadly it still doesnt work. Is it just me, or is it because there is a new version?

BennoCrafter avatar Mar 28 '24 15:03 BennoCrafter

Same issue. Using expo 50

MathiasSvDK avatar Mar 30 '24 03:03 MathiasSvDK

It works, you only need to use this version npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes And you need to make a change inside the backdrop component in order to make it work on android. Just change View, to AnimatedBlurView

mimo-10 avatar Mar 30 '24 19:03 mimo-10

Just for android?

BennoCrafter avatar Mar 30 '24 20:03 BennoCrafter

Yes, you need to do that only for android, for ios it works without any changes.

mimo-10 avatar Mar 30 '24 23:03 mimo-10

Im having trouble trying to install this fork.. 🤔 any ideas?

❯ npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
zsh: no matches found: https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

tconroy avatar Jun 21 '24 04:06 tconroy

@tconroy It works for me 😅

Nasseratic avatar Jun 21 '24 15:06 Nasseratic

@tconroy It works for me 😅

Yes I just needed to wrap the url as a string and now it works 😊

tconroy avatar Jun 21 '24 15:06 tconroy

Can we merge the upgrade to 49 (also confirming nasseratic's fix works on expo 50) to main

daxaxelrod avatar Jul 18 '24 16:07 daxaxelrod