Thomas E Enebo

Results 276 comments of Thomas E Enebo

@andrewstein @headius Unless something outside JRuby is using InstanceVariableFinder then it is dead code. There is no reference to it. I can only see @headius and @chrisseaton touching this about...

@headius It is a huge lists of lambdas being called from a single method. Any change in performance in executing the same code I think would be from the JVM...

@CufeHaco This looks promising. Your benchmark results above are for the new implementation relative to MRI or is it with your new impl. I can see in your repo you...

@JesseChavez Do you have any idea on the massive regression on postgresql tests? I do not think it has anything to do with your PR but we seem to no...

@chadlwilson that first loaderror is pretty odd. If I try and load it I can see it: ```text java -jar jruby-complete-9.4.7.0.jar -r jruby -e 'p $LOADED_FEATURES' ["java.rb", "jruby/util.rb", "enumerator.rb", "rational.rb",...

Unrelated to `jruby` not loading but all that code after that point assumes we are either Ruby 1.8 or Ruby 1.9 implementation but we have be a 2+ impl for...

@chadlwilson I am also guessing the booter does not remove the include directory so require jruby.rb probably would normall work but this spec is doing something special. Random thoughts: 1....

@chadlwilson sorry I missed your last comments. I am not sure if this is still valid or not and I do not see any obvious rack documentation on this (although...

@chadlwilson I decided to look a little bit. In trying to just run rake instead of full maven run I had to tweak: ```diff diff --git a/Rakefile b/Rakefile index 599ce7b..19f50a2...