link-checker icon indicating copy to clipboard operation
link-checker copied to clipboard

Support domain-local links and relative paths when crawling

Open lilith opened this issue 11 years ago • 4 comments

This seems like a bug to me - shouldn't internal link correctness be more important than external link correctness?

lilith avatar Mar 06 '13 14:03 lilith

I believe that the link-checker was originally developed to check links in Octopress blogs. Octopress is a static blog site generator so it is unlikely that internal links would be broken as the pages and links are generated programmatically. Obviously if you are using the link-checker in a different environment then your link checking priorities may be different.

mttrb avatar Mar 06 '13 16:03 mttrb

If this is intended behaviour, then there should be a big warning about it in the readme! I realise now that the introduction says "external links" a number of times but the subtlety escaped me before.

As for Octopress, any blog post could link to another internal blog post, so that's not really any different from a jekyll site or anything else. There's still a chance that your internal link is wrong (e.g. typo) and that it won't get picked up by this tool.

gravitystorm avatar Jun 20 '13 16:06 gravitystorm

I agree, it needs to support relative links. That has already been fixed, I just need to push out a new version. I've been having problems dealing with issues and pull requests for this project because of a little baby who sucks up all of my time, but I'll try to merge in the remaining pull requests and release a new version this weekend.

I built this gem because I needed something for checking links in Octopress/Jekyll sites, but I always intended it to be able to scan any kind of site. It's not intended to be tied specifically to Octopress.

endymion avatar Jun 21 '13 15:06 endymion

@endymion awesome - I look forward to the new version, and understand completely about other time commitments.

gravitystorm avatar Jun 24 '13 08:06 gravitystorm