endo icon indicating copy to clipboard operation
endo copied to clipboard

ses-ava is missing a `todo` method

Open erights opened this issue 4 years ago • 4 comments

While doing https://github.com/Agoric/agoric-sdk/pull/2733 I discovered that our code uses test.todo occasionally but ses-ava does not yet support it.

@FUDCo you wanna?

erights avatar Mar 27 '21 04:03 erights

Let's close this.

FUDCo avatar Feb 03 '22 20:02 FUDCo

Close as in "it's already fixed, let's close the bug" or "let's fix this"?

erights avatar Feb 03 '22 20:02 erights

As in "do we seriously care about this enough to, like, spend time on it?"

FUDCo avatar Feb 03 '22 20:02 FUDCo

Sorry, yes we do. I see test.todo in 7 files in agoric-sdk. Six of these, as a result, are using ava when they should be using ses-ava. This causes diagnostic info to be lost and creates a lousy developer experience.

Doesn't need to be fixed by MN-1, but definitely needs to be fixed.

erights avatar Feb 03 '22 21:02 erights

Closing as a case of the more general problem https://github.com/endojs/endo/issues/647

turadg avatar Dec 24 '22 22:12 turadg