endo icon indicating copy to clipboard operation
endo copied to clipboard

fix(ses): reject unsupported lockdownOptions mathTaming + dateTaming

Open kumavis opened this issue 1 year ago • 3 comments

This is a breaking change.

support for lockdown options mathTaming and dateTaming were removed so long ago I'm having trouble finding a proper reference (edit: july 2020 https://github.com/endojs/endo/pull/372). Since these options don't do anything, lockdown should fail when these options are specified.

For LavaMoat, we were surprised to find they were being provided to lockdown, but had no effect. Any other unrecognized lockdown options are rejected.

Here is a non-breaking change that adds a warning when the options are specified https://github.com/endojs/endo/pull/2584

kumavis avatar Oct 11 '24 21:10 kumavis

@kriskowal unrelated playwright install issue (?)

kumavis avatar Oct 11 '24 21:10 kumavis

@kriskowal unrelated playwright install issue (?)

Definitely unrelated. We saw this once before when one of the browsers shifted underneath us. I reran the job and it persisted. It’s not a required job.

kriskowal avatar Oct 12 '24 00:10 kriskowal

@kriskowal whats the process for queueing breaking changes?

kumavis avatar Oct 12 '24 06:10 kumavis

@kriskowal whats the process for queueing breaking changes?

We do not have one yet, but I think a new label next-major is in order. The queue is not empty (__options__ on Compartment options bag, deprecated module descriptor formats, &c.)

Closing in favor of https://github.com/endojs/endo/pull/2584

kriskowal avatar Oct 30 '24 20:10 kriskowal