endo icon indicating copy to clipboard operation
endo copied to clipboard

fix(ses,pass-style,marshal): fix #2428 permit disposal intrinsics

Open erights opened this issue 1 year ago • 1 comments

Staged on #2841

Closes: #2428 Refs: #2223 #2891

Description

https://github.com/tc39/proposal-explicit-resource-management has reached stage 4, so we should permit its intrinsics before it gets rolled out widely.

Besides, once it is available on enough target platforms, we'd like to start using it.

This PR merely adds special cases for SuppressedError paralleling the special cases we already had for AggregateError. A follow-on PR #2223 should generalize the handling of novel safe error properties so we no longer need to do such bespoke error handling.

Security Considerations

While https://github.com/tc39/proposal-explicit-resource-management was going through stages, we were involved and believe that the proposal as accepted has no security issues. This PR unconditionally permits it with no further repair under the assumption that all platforms of interest, if they implement it at all, implement it correctly.

Scaling Considerations

For this PR by itself, none.

https://github.com/tc39/proposal-explicit-resource-management should help us write code that more reliably cleans up after itself, which should help scalability.

Documentation Considerations

By supporting https://github.com/tc39/proposal-explicit-resource-management before it is widely available, we avoid the need to document its omission.

Testing Considerations

  • [ ] need tests for SuppressedError handling that parallels the tests we have for AggregateError

Compatibility Considerations

As with AggregateError, we need to make sure that SuppressedError can be received correctly by all endpoints of interest before we can start sending it.

Upgrade Considerations

  • [ ] update all relevant NEWS.md files.

erights avatar Aug 27 '24 02:08 erights

Converting to Draft because its current form is too messy to consider as a candidate. I'll let you know when it is again ready for review.

erights avatar Aug 27 '24 21:08 erights