endo icon indicating copy to clipboard operation
endo copied to clipboard
verified publisher icon endojs

Ecosystem Compatibility (2024-02-05 onward)

Open kriskowal opened this issue 1 year ago • 12 comments

Index of ecosystem compatibility notes from 2021-02-10 to 2024-02-05 https://github.com/endojs/endo/discussions/1950 with updates to follow in subsequent comments and separate issues with the label ecosystem-compatibility.

  • axios

    • https://github.com/axios/axios/issues/6264

  • babel

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073906
    • https://github.com/endojs/endo/issues/1846

  • buffer

    • 2021-03-06 https://github.com/Agoric/agoric-sdk/issues/2663

  • chalk

    • ^4
      • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073908

  • core-js

    • https://github.com/zloirock/core-js/issues/1092

  • @cosmjs/types

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073906

  • crypto-js 909,612 downloads/week

    • overriding toString via computed set (this[propertyName] = properties[propertyName]) https://github.com/brix/crypto-js/blob/8e6d15bf2e26d6ff0af5277df2604ca12b60a718/src/core.js#L132
    • Setting via computed assign previously defeated my babel-plugin workaround, but @kumavis added support for it

  • d3

    • 2021-03-03 Fixed https://github.com/Agoric/agoric-sdk/pull/2575

  • deep-equal 6,532,310 downloads / week

    • 1.0.1 accidentally assigns "shim" to Object.keys https://npmfs.com/package/deep-equal/1.0.1/lib/keys.js

  • enzyme

    • 2021-02-10 Good news about JSS and enzyme Agoric/agoric-sdk#2321 (comment)

  • follow-redirects

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073906

  • @formatjs/intl-utils

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073859

  • gun

    • https://github.com/amark/gun/pull/1217

  • immerjs

    • https://github.com/immerjs/immer/pull/914
    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073903

  • jss

    • 2021-02-10 Good news about JSS and enzyme Agoric/agoric-sdk#2321 (comment)

  • luxon

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073858

  • mobx

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8350485
      • https://github.com/endojs/endo/pull/2030

  • node

    • Confuses constructor accessor in log messages https://github.com/Agoric/agoric-sdk/issues/2324
    • https://github.com/nodejs/node/issues/43496
    • https://github.com/nodejs/node/pull/43907
    • https://github.com/nodejs/node/pull/59456

  • node-external-editor

    • https://github.com/mrkmg/node-external-editor/issues/25

  • pino

    • https://github.com/pinojs/pino/pull/1939

  • protobuf

    • https://github.com/protobufjs/protobuf.js/pull/1742
    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073906
    • https://github.com/protobufjs/protobuf.js/issues/1713

  • react

    • https://github.com/endojs/endo/pull/642
    • https://github.com/endojs/endo/issues/612
    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073867

  • readable-steam

    • https://github.com/nodejs/readable-stream/pull/474

  • reflect-metadata

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073905

  • rxjs

    • https://github.com/web3/web3.js/pull/4918
    • https://github.com/ReactiveX/rxjs/pull/6991

  • regenerator-runtime

    • https://github.com/endojs/endo/issues/621
    • https://github.com/facebook/regenerator/issues/410
    • https://github.com/facebook/regenerator/pull/411

    impacted by use of regnerator-runtime https://github.com/endojs/endo/discussions/1950#discussioncomment-8073881

    • @ceramicnetwork/rpc-transport
    • @ceramicstudio/idx
    • @uniswap/v3-sdk
    • key-did-provider-ed25519
    • rpc-utils (before 0.6.0)

  • rollup

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073879

  • stack-utils

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073902

  • symbol-observable

    • 6,602,849 downloads / week

    tries to mutate Symbol https://github.com/benlesh/symbol-observable/blob/e56e765476fd96dcb430fd44d936bc543d4d97ba/es/ponyfill.js#L9-L10

  • tape

    • 2020-09-23 Fear that tape overrode Function.prototype.apply cleared by @ljharb at #474

  • typescript

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073877
    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073906

  • underscore 6,453,579 downloads / week

    • overriding Object.prototype properties https://github.com/jashkenas/underscore/blob/36eef3c118041ae6386b6bba2b48b099e57ca0e5/underscore.js#L1676
    • overriding Function.prototype properties https://github.com/jashkenas/underscore/blob/36eef3c118041ae6386b6bba2b48b099e57ca0e5/underscore.js#L772

  • @wry/context

    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073868
    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073869
    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073870
    • https://github.com/endojs/endo/discussions/1950#discussioncomment-8073878

  • vega

    • 2021-02-10 Fixed https://github.com/Agoric/agoric-sdk/pull/2321#issuecomment-777099286
    • 2021-03-03 Fixed https://github.com/Agoric/agoric-sdk/pull/2575
    • https://github.com/vega/vega/pull/3109
    • https://github.com/vega/vega/issues/3075

  • ejs 19,955,226 downloads / week

    • attempts to get globalThis ref via Function constructor https://github.com/mde/ejs/pull/779
    • evals templates that look like html comments, so SES throws

kriskowal avatar Feb 06 '24 03:02 kriskowal

TODO: https://github.com/isaacs/minimatch/blob/ef8f2672bdbbf6a632ea815636659fb31b5169aa/src/index.ts#L1012

naugtur avatar Feb 20 '24 10:02 naugtur

TODO: https://github.com/isaacs/minimatch/blob/ef8f2672bdbbf6a632ea815636659fb31b5169aa/src/index.ts#L1012

PR for that is at https://github.com/isaacs/minimatch/pull/228

gibson042 avatar Feb 20 '24 20:02 gibson042

mimic-fn does not compose well with our toString enablements. This manifests as a “Cannot define property with both value and get” (effectively). I have proposed a fix: https://github.com/sindresorhus/mimic-function/pull/51

kriskowal avatar Mar 14 '24 04:03 kriskowal

wouldn't that fix end up setting writable to false when it's a getter, because there's no writable in the first place? or is that fine

ljharb avatar Mar 14 '24 05:03 ljharb

wouldn't that fix end up setting writable to false when it's a getter, because there's no writable in the first place? or is that fine

That’s a good question for @sindresorhus and the intended outcome for mimic-function. I think mirroring a getter with a non-writable value is possibly consistent with the intent.

kriskowal avatar Mar 14 '24 20:03 kriskowal

See https://github.com/endojs/endo/issues/2033#issuecomment-2028956104

Should https://github.com/endojs/endo/issues/2033 be tracked here as an endo ecosystem compat issue?

erights avatar Apr 01 '24 00:04 erights