endo icon indicating copy to clipboard operation
endo copied to clipboard

define Key, PureData using parameterized Passable (WIP)

Open dckc opened this issue 2 years ago • 2 comments

suggestions for #1933

I think the pass-style stuff is complete. The patterns stuff is just a start.

The marshal stuff is probably superfluous.

dckc avatar Jan 10 '24 04:01 dckc

@dckc I rebased https://github.com/endojs/endo/pull/1933 on top of master so I rebased this PR on top of that. https://github.com/endojs/endo/tree/ta/dc-Passable-types has the result.

I don't totally get what it buys. Does it make sense to try getting #1933 into master and coming back to this?

turadg avatar Jan 10 '24 20:01 turadg

I think that's not even a functional change. The Exclude<...> is redundant: the never already says that.

So it's just a refactor for clarity/conciseness.

A few type tests to show that the types are equivalent might be worthwhile.

dckc avatar Jul 10 '24 03:07 dckc