endo icon indicating copy to clipboard operation
endo copied to clipboard
verified publisher icon endojs

[WIP] Shallow harden

Open mhofman opened this issue 2 years ago • 5 comments

refs: #1686

mhofman avatar Dec 29 '23 07:12 mhofman

@erights the use of harden are already in separate commits, but hold off anyway, I'm more thoroughly rewriting the harden implementation to add hooks.

mhofman avatar Dec 30 '23 22:12 mhofman

What about https://github.com/Agoric/agoric-sdk/pull/8700 ? It, likewise, seems to be almost all improvements in the use of harden which would be valuable regardless, and could get merged early. Yes?

erights avatar Dec 30 '23 23:12 erights

The vast majority of of changes in this PR are just generic improvements in use of harden. If you could separate these into a distinct PR, we could probably review and merge that quickly.

@erights I have now done that in https://github.com/endojs/endo/pull/1939. While I have rebased this PR on top of that change (roughly), I do expect to rewrite it significantly to add hooks to fully separate harden from lockdown

mhofman avatar Jan 09 '24 22:01 mhofman

Now that #1939 is merged, please rebase this one for review brevity. Thx.

It's stacked by apparently GH is struggling and didn't update the base ...

mhofman avatar Jan 10 '24 00:01 mhofman

I think if you rebase -i onto current (post merge) master and push --force, that should clean it up. yes?

erights avatar Jan 10 '24 00:01 erights