endo icon indicating copy to clipboard operation
endo copied to clipboard

Consider optimizing bestEffortStringify

Open gibson042 opened this issue 2 years ago • 1 comments

Recent performance analysis shows a lot of time spent in assert.quote, and I wonder if there's misattribution of bestEffortStringify, which can probably be sped up a great deal by bypassing JSON.stringify.

gibson042 avatar Mar 30 '23 23:03 gibson042

I suspect that a lot of this is due to the old assert pattern. I'd wait and re-measure after we're cleanly switched to the || Fail... assert style.

Unless of course we have measurements that indicate that bestEffortStringify is called a lot for some purpose other than assertions.

erights avatar Mar 31 '23 21:03 erights