endoflife.date
endoflife.date copied to clipboard
endoflife-date
[Feature] Better icon support
This creates a new release filter to help parse the releases in code. Using Liquid for generating the actual product page is good for simple prose, but gets too complicated for the remaining part. This can help us move to a simpler codebase, where the complicated parts are handled by the code, and the Liquid parts have very little logic.
This would help us make progress on getting API to parity with the HTML (The goal being to have a Release filter that actually parses the page into something both the API and HTML can consume)
Tried to figure out our performance issues while working on this, and filed https://github.com/just-the-docs/just-the-docs/issues/863
Turns out adding categories will speed up our builds.
Added logos to products that do not have logos such as Almalinux, cfengine and others
A small suggestion , couldnt we make this one
icon:
simpleicons: blender
change something like this :
icon:
iconProvider: "simpleicons"
iconName: "blender"
or maybe if you wish we can combine provider and iconname into one string using @ in its name
icon: "blender@simpleicons"
This approach is more cleaner what do you thing ? @captn3m0 @BiNZGi
I'm okay with the last one if everyone likes it. It's not too confusing for contributors?
My main intent with the PR was to remove the "NA" and automatic detection of icons, and instead force everything to be explicit.
yeah i think it is really cleaner and more understandable for event a new contributor using name@provider syntax and it will make our .md files much shorter and error prune
The files would be shorter indeed but I like to separate details because it is less confusing. The name and the provider of an icon are two separate things and I like it better to have separate. I vote for this proposal:
icon:
iconProvider: "simpleicons"
iconName: "blender"
How about keeping it slightly terse:
icon:
provider: simpleicons
name: blender
Decided against this, icon styles weren't fitting. Better to contribute to SimpleIcons instead.
Closing