endless-sky icon indicating copy to clipboard operation
endless-sky copied to clipboard

Allow missions to deduct more money than the player has by creating a mortgage

Open jafdy opened this issue 9 years ago • 7 comments

If the negative payment can't be made the the money is not deducted. The alternative is to be able to set a mortgage but I don't know how to do that ether.

jafdy avatar Jun 09 '16 08:06 jafdy

I can't get a mission to trigger with an on accept payment costing more than I have. Is this a feature you're requesting? If so give this branch a try: https://github.com/MarcelineVQ/endless-sky/tree/mission-payment

MarcelineVQ avatar Jun 09 '16 12:06 MarcelineVQ

@jafdy i've commented on your pull with the possible explanation, and a check that you need to do.

edit; apparently @MarcelineVQ has already determined that negative payments are not carried, and has committed a fix in the referenced branch: https://github.com/endless-sky/endless-sky/commit/ef9c175450b9211f07dbf58e6bcb402afd586559

LocalGod79 avatar Jun 09 '16 13:06 LocalGod79

That branch should work but it is no use to me if it isn't merged. (not to mention that I haven't worked out how to compile for windows yet)

jafdy avatar Jun 09 '16 15:06 jafdy

It seems to me that having a mission give you a new mortgage but only if its payment is negative and you can't afford the payment is a somewhat confusing behavior. And, it means that it's no longer possible to create missions that are only offered if you have a certain amount of cash on hand (e.g. the "drop bear" attacks in EV Nova). Wouldn't a better option be to allow missions to specify that they apply a new debt to the player, instead? That would have the added advantage that the debt could be at a considerably higher interest rate than a typical mortgage.

endless-sky avatar Jun 11 '16 19:06 endless-sky

That was my preference.

jafdy avatar Jun 11 '16 19:06 jafdy

Wouldn't a better option be to allow missions to specify that they apply a new debt to the player, instead? That would have the added advantage that the debt could be at a considerably higher interest rate than a typical mortgage.

PR #5073 implements this solution

NomadicVolcano avatar May 16 '20 04:05 NomadicVolcano

I have the same issue of not knowing if the player has the money or not and not wanting to branch too much, but I just use fines all the time, and try to justify them. Granted its not as flexible as a fully fledged out mortage.

Hurleveur avatar Feb 19 '24 11:02 Hurleveur