flutter_pdfview icon indicating copy to clipboard operation
flutter_pdfview copied to clipboard

Published 20 hours ago • verified publisher icon endigo

aded support: spacing, enableDoubletap, setBackgroundColor (only android for now), onTap callback, zoom parameters (min, mid, max)

Open lcyper opened this issue 2 years ago • 4 comments

also i upgraded gradle versions

lcyper avatar Feb 16 '22 21:02 lcyper

correct description:

aded support:

  • spacing between pages,
  • enableDoubletap, (to enable zoom)
  • setBackgroundColor (only android for now),
  • onTap callback, (to add custom functionality)
  • zoom parameters (min, mid, max)

lcyper avatar Nov 02 '22 15:11 lcyper

@endigo This PR adds value to the package. What is preventing it from being approved?

charlieforward9 avatar Nov 03 '22 03:11 charlieforward9

@endigo I sent a message 18 days ago and am still facing the same question. I have an application to demo in 1 week that depends on this repository. It would be helpful to merge this PR for a more sophisticated UX.

At a minimum, I am requesting that the setZoom be added: (as done in this commit) https://github.com/endigo/flutter_pdfview/pull/173/commits/2a527feade40ed121dc4cfa855df09354f18f00f

Thank you for contributing to the open-source community.

charlieforward9 avatar Nov 20 '22 17:11 charlieforward9

@endigo When will be merged this PR?

mjablecnik avatar Aug 02 '23 11:08 mjablecnik