Petr Viktorin

Results 185 comments of Petr Viktorin

The patch predates me, and I wasn't very familiar with it. Now that I look at it — the downstream patch is wrong. See details below; short story is that...

I'm not sure about best practices for `test/support`. @vstinner or @erlend-aasland, any comments on the `@requires_limited_api` decorator?

I also plan to add some instructions for the devguide, mentioning the structure for a `Modules/testcapi/*.c` file: ```c #define Py_LIMITED_API 0x03... #include "parts.h" #ifdef LIMITED_API_AVAILABLE (all content goes here) #endif...

This happens to move `#undef NDEBUG` and so it should fix `assert` warnings reported in #96017

I don't understand the failure on the Windows buildbot: ``` 6>PrepareForBuild: Creating directory "C:\Workspace\buildarea\pull_request.linaro-win-arm64.nondebug\build\PCbuild\obj\312arm64_Release\_testcapi\_testcapi.tlog\". InitializeBuildStatus: Creating "C:\Workspace\buildarea\pull_request.linaro-win-arm64.nondebug\build\PCbuild\obj\312arm64_Release\_testcapi\_testcapi.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified. ClCompile: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.31.31103\bin\HostX86\arm64\CL.exe /c /I"C:\Workspace\buildarea\pull_request.linaro-win-arm64.nondebug\build\Include" /I"C:\Workspace\buildarea\pull_request.linaro-win-arm64.nondebug\build\Include\internal" /I"C:\Workspace\buildarea\pull_request.linaro-win-arm64.nondebug\build\PC"...

@python/windows-team, do you know what's wrong [here](https://buildbot.python.org/all/#/builders/738/builds/1192), by any chance?

Woohoo! That worked! Thanks for the wincantation, Steve, and thanks Erlend for the review! The other buildbot failures are unrelated, and being handled in #96006 and #95898

Could you convert the EOL table as well? https://devguide.python.org/devcycle/#end-of-life-branches

GitHub adds Co-Authored-By when squashing a PR with multiple authors. I'm pretty sure Miss Islington (the auto-merge bot) does as well. So as long as you don't squash/rewrite the commits,...

Oh, and: You're clearly thinking about how the other people involved will feel. I think that's more important than a ~~documented~~ rigid process :)