decomp-toolkit icon indicating copy to clipboard operation
decomp-toolkit copied to clipboard

[BUG] main thread panicks when running dol info command

Open emannotava opened this issue 1 year ago • 1 comments

Repository URL

No response

Game Name

Pokémon Rumble

Game Version

USA v1

Description

So after extracting Pokémon Rumble's WAD I tried to generate some info for its dol file (which is called 00000001.app but is the game's dol in reality) And it almost immediately panicks and returns this error: image-190

I've tried it using both the base game and the well-known Weekend Edition mod of the game which contains a few minor code changes.

However both yield the aforementioned result.

encounter themselves said it must be a bug over on the discord and told me I should report it as an issue on the github.

If I need to provide any files so you've got sample data to experiment with, do let me know.

emannotava avatar Dec 27 '24 16:12 emannotava

Pokémon Rumble's 00000001.app is compressed with "nlzss" aka "lz11" aka "lz77ex". So, this statement:

dol file [...] is called 00000001.app but is the game's dol in reality

is incorrect.

You used a compressed archive of the dol, not the actual dol; the invalid file caused the panic. You have to decompress it first.

maybe there's some way to validate that a dol file is valid, to give an error message instead of a panic?

KooShnoo avatar Dec 27 '24 16:12 KooShnoo