decomp-toolkit icon indicating copy to clipboard operation
decomp-toolkit copied to clipboard

[BUG] "dtk rel merge" falsely assumes each module ID must be unique

Open jummy0 opened this issue 1 year ago • 1 comments

Repository URL

No response

Game Name

Dance Dance Revolution Mario Mix

Game Version

USA

Description

Dance Dance Revolution Mario Mix enumerates REL modules dynamically at runtime, in alphabetical order by filename. The files all use an ID of 1. dtk would not accept these REL files until i manually gave them unique ID's.

Presumably, this also affects Dance Dance Revolution Hottest Party, which is based on Mario Mix.

jummy0 avatar Dec 16 '24 22:12 jummy0

RELs with the same ID aren't supposed to be loaded simultaneously. Mario Party similarly links RELs individually (which causes the duplicate IDs) so that they can't reference each other. But for this use case, the workaround of giving each REL a unique ID is pretty reasonable. dtk could have an option to do that internally, so I'll keep this open.

encounter avatar Jan 28 '25 01:01 encounter