uvicorn icon indicating copy to clipboard operation
uvicorn copied to clipboard

Websocket sansio implementataion

Open gourav-kandoria opened this issue 1 year ago • 16 comments

This PR provides the implementation of websocket protocol using websockets sansI/O layer.

task details - https://github.com/encode/uvicorn/issues/1908

Checklist for @Kludex

  • [ ] data_receive shouldn't be using Exception. What is the right exception there?
  • [X] Check if max_size is being tested, and if not, test it. EDIT: I've checked it - it's not being tested.
  • [ ] Add WebSocketsSansIOProtocol test for max_size.
  • [x] Should we remove CONT and PONG related code?
  • [ ] Add documentation.
  • [x] Increase the coverage number.
  • [x] Add --ws websockets-sansio.
  • [ ] Check if https://github.com/encode/uvicorn/pull/2060#discussion_r1277501171 is true.
  • [ ] Answer the following questions:
    • [ ] Should we deprecate websockets legacy version?
    • [ ] Should we add a UserWarning saying that it's experimental, and asking users to comment in a discussion X?

gourav-kandoria avatar Jul 27 '23 12:07 gourav-kandoria